Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up a Grafana dashboard with results for FT benchmark #11405

Closed
Tracked by #11348
aborg-dev opened this issue May 28, 2024 · 4 comments
Closed
Tracked by #11348

Set up a Grafana dashboard with results for FT benchmark #11405

aborg-dev opened this issue May 28, 2024 · 4 comments
Assignees
@mooori

Comments

@aborg-dev
Copy link
Contributor

aborg-dev commented May 28, 2024 •
edited
Loading

We want to have a dashboard where we can see the results of Locust FT benchmark runs.
The basic table that we show there should include:

  • Date when benchmark was executed
  • Git commit at which nearcore was built
  • Peak number of transactions per second that the network was able to process
@aborg-dev aborg-dev mentioned this issue May 28, 2024
Closed
@aborg-dev aborg-dev changed the title Set up a Grafana dashboard with results Set up a Grafana dashboard with results for FT benchmark May 28, 2024
@aborg-dev
Copy link
Contributor Author

@mooori , we need to come up with the database schema for storing the metrics, can you propose something that covers the fields that I've mentioned above?

@MCJOHN974
Copy link
Contributor

Peak number of transactions per second that the network was able to process

Do we really want peak? Maybe some percentile will be better? (or both)

@aborg-dev
Copy link
Contributor Author

Peak number of transactions per second that the network was able to process

Do we really want peak? Maybe some percentile will be better? (or both)

Yes, that was a bad phrasing from my end - we want a peak sustained/stable throughput. Probably some percentile as you say.

However, for the schema design, it is out of scope to decide how exactly we will compute that number, so let's discuss that separately.

@mooori mooori mentioned this issue May 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 30, 2024
@mooori
bench/ft_transfer: add db table (#11418)
017871b 
Related to #11405.

Not sure if this directory makes sense, but I couldn't find another
place where this should obviously be. I'd like to push more files with
code/commands related to db setup and admin, so I think having a
dedicated directory can be useful.

Proposing this table as a starting point, probably we'll have multiple
iterations anyway as benchmarks are fleshed out.
@aborg-dev
Copy link
Contributor Author

Here is the Grafana dashboard for the benchmarks: https://nearone.grafana.net/d/fdo204e4y88owa/continouos-benchmarks?orgId=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mooori mooori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aborg-dev @mooori @MCJOHN974