Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose chunk header from shards manager to unblock endorsement processing #11423

Closed
Longarithm opened this issue May 30, 2024 · 1 comment
Closed

Expose chunk header from shards manager to unblock endorsement processing #11423

Longarithm opened this issue May 30, 2024 · 1 comment
Labels
A-stateless-validation Area: stateless validation

Comments

@Longarithm
Copy link
Member

While working on #11422, I discovered that some chunk is always missing.
The reason was that some node was always waiting to get complete chunk, which is not necessarily guaranteed.
We should consider either to wait only for chunk header, or guarantee all chunk completion on BPs, or something else.
@Longarithm Longarithm added the A-stateless-validation Area: stateless validation label May 30, 2024
@Longarithm Longarithm mentioned this issue May 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 30, 2024
@Longarithm
refactor: readability of chunk management tests, process stateless va…
6580d37 
…lidation messages (#11425)

* Separate default peer network message processing to a function
`process_peer_manager_message_default`, reducing nesting level.
* Process stateless validation-related messages in the end of it.
* Remove near-useless genesis block retrieval.
* Bind partial witness actor to client to ensure messages propagation.

Still not enough to enable tests on nightly due to #11423, but makes
tests more readable and closer to that.
@Longarithm
Copy link
Member Author

Not needed, #11436 was enough.

@Longarithm Longarithm closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Longarithm