-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_key_cost.function_call_cost_per_byte is not correctly calculated from #3037
Comments
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. |
@ailisp what is the status of this issue? |
@bowenwang1996 Examined it's still not fixed. Most recent fee update to add_key_cost.function_call_cost_per_byte is this https://github.com/near/nearcore/commits/master/scripts/migrations/11-runtime-cost-adjustment.py, the number of this cost matches fees.rs, which is prior to this issue. |
Okay. @Longarithm please keep this issue in mind when you recalculate the gas costs. |
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. |
@Longarithm is the recalculation done? |
@bowenwang1996 yes, together with data receipt costs: https://hackmd.io/w6ODyKjUReuuofXTuqdyFQ |
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. |
This issue has been automatically marked as stale because it has not had recent activity in the last 2 months. |
We found #2621 introduced a typo, which cause
add_key_cost.function_call_cost_per_byte
1000x more than correct. But besides that, there probably a copy-paste error in f024a28, this cause add_key_cost.function_call_cost_per_byte 10000x less than correct. As a result add_key_cost.function_call_cost_per_byte now is about 10x less than correct.For correct I mean the result i got from rerun param estimator several time in between f024a289 and current master, in both cloud&locally, result is almostly not changed, so it's very likely correct
10x in add function call access key per byte cost is acceptable, we need to correct it some time in future, but must do it in a backward compatible way. In rust check protocol version and apply different fees.
The text was updated successfully, but these errors were encountered: