Expose max_gas_burnt_view as part of client config
#3080
Comments
|
I ran into the GasLimitExceeded error in my contract when calling the read function. I started looking for where to change the gas limit in the node configuration. I have not found documentation for client configs anywhere. By examining the source code, it turned out that this parameter lies in the genesis (genesis.json), which is 5 GB in size. The built-in Linux text editors didn't want to work with such a large file. I discovered a HEX editor that can handle this. Replaced 200Tgas with 999Tgas. Launched the client. It noticed the change by comparing the genesis hashes and cleared the entire state. Well, the synchronization of the node started from the very beginning. So, now it's impossible to change the gas limit for view functions. |
The config you modified is in genesis and is part of the protocol, so that doesn't work. What is proposed here is to add a separate client config that does not affect the protocol to increase the limit on view calls. |
|
Yes, please fix the issue. It should be a no-brainer fix, max 10 lines of code to replace the source where the read-only gas limit comes from, isn't it? |
The ‘max_gas_burnt_view’ affects the RPCs only and as such does not change the protocol. Therefore it does not need to be part of the consensus and all nodes could have this value customised rather than using an agreed upon value from genesis runtime configuration. Introduce a ‘max_gas_burnt_view’ field to ClientConfig and a corresponding flag to ‘init’ subcommand. When present, it will override the limit used by the node ignoring whatever is stored in genesis configuration. Fixes: near#3080
The ‘max_gas_burnt_view’ affects the RPCs only and therefore doesn’t need to be part of the consensus. In other words, all nodes could have this value customised rather than using an agreed upon value from genesis configuration. Introduce a ‘max_gas_burnt_view’ field to ClientConfig and a corresponding flag to ‘init’ and ‘run’ subcommands. When present, it will override the limit used by the node ignoring whatever is stored in genesis configuration. Fixes: near#3080
The ‘max_gas_burnt_view’ affects the RPCs only and therefore doesn’t need to be part of the consensus. In other words, all nodes could have this value customised rather than using an agreed upon value from genesis configuration. Introduce a ‘max_gas_burnt_view’ field to ClientConfig and a corresponding flag to ‘init’ and ‘run’ subcommands. When present, it will override the limit used by the node ignoring whatever is stored in genesis configuration. Fixes: near#3080
The ‘max_gas_burnt_view’ affects the RPCs only and therefore doesn’t need to be part of the consensus. In other words, all nodes could have this value customised rather than using an agreed upon value from genesis configuration. Introduce a ‘max_gas_burnt_view’ field to ClientConfig and a corresponding flag to ‘init’ and ‘run’ subcommands. When present, it will override the limit used by the node ignoring whatever is stored in genesis configuration. Fixes: near#3080
The ‘max_gas_burnt_view’ affects the RPCs only and therefore doesn’t need to be part of the consensus. In other words, all nodes could have this value customised rather than using an agreed upon value from genesis configuration. Introduce a ‘max_gas_burnt_view’ field to ClientConfig and a corresponding flag to ‘init’ and ‘run’ subcommands. When present, it will override the limit used by the node ignoring whatever is stored in genesis configuration. Fixes: near#3080
…4381) The ‘max_gas_burnt_view’ affects the RPCs only and therefore doesn’t need to be part of the consensus. In other words, all nodes could have this value customised rather than using an agreed upon value from genesis configuration. Introduce a ‘max_gas_burnt_view’ field to ClientConfig and a corresponding flag to ‘init’ and ‘run’ subcommands. When present, it will override the limit used by the node ignoring whatever is stored in genesis configuration. Fixes: #3080
|
This isn’t yet available in a production release but if anyone wishes to test it in betanet et al with a nightly build |
max_gas_burnt_viewdefines the maximum burnt gas for a view call.Since it doesn't influence the protocol (only affects RPC), it should be part of the client config instead of genesis config.
The text was updated successfully, but these errors were encountered: