Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompute gas costs for function call base and data creation #4401

Closed
bowenwang1996 opened this issue Jun 23, 2021 · 5 comments
Closed

Recompute gas costs for function call base and data creation #4401

bowenwang1996 opened this issue Jun 23, 2021 · 5 comments
Assignees
Labels
A-contract-runtime Area: contract compilation and execution, virtual machines, etc A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) T-core Team: issues relevant to the core team

Comments

@bowenwang1996
Copy link
Collaborator

bowenwang1996 commented Jun 23, 2021

Function call base cost should be dramatically reduced after #4344 is merged. Also we did not correctly estimate the cost for data receipt creation (right now it costs 9.4Tgas for every promise near/NEPs#120 (comment)). We should recompute those gas costs together and make one protocol upgrade to change them.

@bowenwang1996 bowenwang1996 added the A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) label Jun 23, 2021
@bowenwang1996
Copy link
Collaborator Author

bowenwang1996 commented Jun 28, 2021

@Longarithm please sync with @olonho on how to recompute the costs now that #4311 is addressed

@bowenwang1996 bowenwang1996 added A-contract-runtime Area: contract compilation and execution, virtual machines, etc T-core Team: issues relevant to the core team labels Jun 28, 2021
@Longarithm Longarithm linked a pull request Jul 2, 2021 that will close this issue
@stale
Copy link

stale bot commented Sep 26, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Sep 26, 2021
@stale
Copy link

stale bot commented Dec 25, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Dec 25, 2021
@stale
Copy link

stale bot commented Mar 29, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@Longarithm
Copy link
Member

Data receipt costs were reduced in protocol feature LowerDataReceiptAndEcrecoverBaseCost (protocol version 48), function call costs were reduced in DecreaseFunctionCallBaseCost (66) by Contract Runtime team. Good example of how much more work was actually required...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contract-runtime Area: contract compilation and execution, virtual machines, etc A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) T-core Team: issues relevant to the core team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants