Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all of the nearcore tests into a single compilation unit #4469

Closed
matklad opened this issue Jul 7, 2021 · 2 comments
Closed

Move all of the nearcore tests into a single compilation unit #4469

matklad opened this issue Jul 7, 2021 · 2 comments
Assignees
@nikurt
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-housekeeping Category: Refactoring, cleanups, code quality Node Node team T-node Team: issues relevant to the node experience team

Comments

@matklad
Copy link
Contributor

matklad commented Jul 7, 2021

At the moment we have test crates in nearcore/tests, we should unify them into one test crate. I started doing that in #4263, but that bitrotted.

See #4027 for why this would be better.

Should be done after #4468 -- the lazy_static issue actually prevents moving some tests into a single binary.
@matklad matklad added C-housekeeping Category: Refactoring, cleanups, code quality A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) labels Jul 7, 2021
@bowenwang1996 bowenwang1996 added the T-node Team: issues relevant to the node experience team label Jul 8, 2021
@stale
Copy link

stale bot commented Nov 9, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Nov 9, 2021
@bowenwang1996
Copy link
Collaborator

@matklad I believe this is fixed. Please reopen if that is not the case

@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikurt nikurt

Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-housekeeping Category: Refactoring, cleanups, code quality Node Node team T-node Team: issues relevant to the node experience team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gmilescu @matklad @bowenwang1996 @nikurt