refactor: improve test compilation speed and organization #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
approved these changes
Mar 3, 2021
ailisp
approved these changes
Mar 3, 2021
By moving from many integration binaries to unit-tests, we: * improve test compilation performance by cutting down on linking time significantly * improve test run-time by increasing parallelism (20s -> 12s, when `test_out_of_memory` outlier is removed) * improve organization by making more things private and making it easier to share code between various tests. See this post for in-depth explanation: https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html When adding a new integration test file, consider an option of putting it into `src` dir instead.
matklad
added a commit
to matklad/nearcore
that referenced
this pull request
Apr 29, 2021
See near#4027 for discussion why this layout is better. TL;DR is that we don't re-link neard repeatedly. As a cherry on top, we now get to proprely share NodeCluster code between the tests, instead of it being compiled afresh for each test.
matklad
added a commit
to matklad/nearcore
that referenced
this pull request
Apr 30, 2021
See near#4027 for discussion why this layout is better. TL;DR is that we don't re-link neard repeatedly. As a cherry on top, we now get to proprely share NodeCluster code between the tests, instead of it being compiled afresh for each test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving from many integration integration test crates to a single (nested) unit-tests module, we:
significantly
test_out_of_memoryoutlier is removed)easier to share code between various tests.
See this post for an in-depth explanation:
https://matklad.github.io/2021/02/27/delete-cargo-integration-tests.html
When adding a new integration test file, consider an option of putting
it into
srcdir instead.