Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to borsh 0.9 #4603

Closed
matklad opened this issue Jul 30, 2021 · 0 comments · Fixed by #4730
Closed

Upgrade to borsh 0.9 #4603

matklad opened this issue Jul 30, 2021 · 0 comments · Fixed by #4730
Labels
C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. C-housekeeping Category: Refactoring, cleanups, code quality Node Node team P-low Priority: low T-node Team: issues relevant to the node experience team

Comments

@matklad
Copy link
Contributor

matklad commented Jul 30, 2021

Most nearcore crates use borsh 0.8. Some use 0.9 though. We should update all to 0.9
@matklad matklad added C-housekeeping Category: Refactoring, cleanups, code quality C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. T-node Team: issues relevant to the node experience team labels Jul 30, 2021
@austinabell austinabell mentioned this issue Aug 4, 2021
Closed
@bowenwang1996 bowenwang1996 added the P-low Priority: low label Aug 17, 2021
@austinabell austinabell mentioned this issue Aug 24, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue Sep 8, 2021
@austinabell
chore: bump borsh version (#4730)
e974f15 
Closes #4603 

I think the zeropool_bn borsh version still needs to be updated. I'm still tracking down which fork is being published from because it doesn't seem to be the near or aurora fork of bn (can someone save me time and point in right direction?). 

What I'm confused about is why the cargo-deny doesn't fail when specifying 0.9 borsh and checking ban conditions
@gmilescu gmilescu added the Node Node team label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. C-housekeeping Category: Refactoring, cleanups, code quality Node Node team P-low Priority: low T-node Team: issues relevant to the node experience team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump borsh version near/nearcore
3 participants
@gmilescu @matklad @bowenwang1996