Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EcRecover Base update #4861

Closed
joshuajbouw opened this issue Sep 23, 2021 · 2 comments · Fixed by #4865
Closed

EcRecover Base update #4861

joshuajbouw opened this issue Sep 23, 2021 · 2 comments · Fixed by #4865
Assignees
@birchmd
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) T-Aurora Team: issues relevant to the Aurora team

Comments

@joshuajbouw
Copy link
Member

As requested per #4778 (comment), we need to update the EcRecover costs to what @matklad has observed.

This should follow along of the lines of the work done here: #4795.
@joshuajbouw joshuajbouw added the A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) label Sep 23, 2021
@matklad matklad added the T-Aurora Team: issues relevant to the Aurora team label Sep 23, 2021
@birchmd birchmd mentioned this issue Sep 23, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue Sep 28, 2021
@birchmd
Feat: decrease ecrecover base cost (#4865)
423e637 
Closes #4861

See the issue for details.

Test plan: check cost is lowered
@matklad
Copy link
Contributor

matklad commented Oct 8, 2021

@joshuajbouw @birchmd we probably want to stabilize lower costs befere the next release, right? If that's the case, could you submit a stabilization PR? See #4948 for one example, and #4953 (comment) for some non-normative notes on the process.

@matklad
Copy link
Contributor

matklad commented Oct 8, 2021

Ah, no, #4948 actually includes lowered ecrecover cost, so you might just want to look at that PR/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@birchmd birchmd

Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) T-Aurora Team: issues relevant to the Aurora team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: decrease ecrecover base cost near/nearcore
3 participants
@matklad @joshuajbouw @birchmd