-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick flat state removal for non-tracked shard #8332
Comments
@Longarithm let's consider the following layout with 3 shards:
What would the range we can use when cleaning shard with index 1 (with all keys before |
Hm I didn't realize that there is a plan to put subaccounts of a fixed account to the same shard. This is confusing because resharding of such shards will be computation-heavy. Asked in Zulip https://near.zulipchat.com/#narrow/stream/295558-pagoda.2Fcore/topic/fixed.20shards/near/320919706 |
Discussed offline: it is fine to ignore subaccounts feature because fixing single account is enough. Though we don't want to drop fixed accounts completely because in theory they could allow us to quickly move some large account to a separate shard. |
Update: we've decided not to implement it for now. This requires removing subaccounts support for accounts in |
Use range deletion in `clean_state` when removing values from `FlatState` column. Addresses #8332
Use range deletion in `clean_state` when removing values from `FlatState` column. Addresses #8332
Use range deletion in `clean_state` when removing values from `FlatState` column. Addresses near#8332
Use range deletion in `clean_state` when removing values from `FlatState` column. Addresses near#8332
Use range deletion in `clean_state` when removing values from `FlatState` column. Addresses #8332
The original idea was to use
delete_range
introduced in #8200 when cleaning flat state. That doesn't work due to sub-accounts for fixed shards.With #8670 we can just remove all keys with a given
shard_uid
prefix.The text was updated successfully, but these errors were encountered: