Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace all remaining uses of num_shards() with shard_ids() #10271

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

akhi3030
Copy link
Collaborator

Closes #10237

@akhi3030 akhi3030 requested a review from a team as a code owner November 30, 2023 15:30
@akhi3030 akhi3030 requested a review from nikurt November 30, 2023 15:30
@akhi3030 akhi3030 added this pull request to the merge queue Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (935cc98) 71.80% compared to head (b4d0dd4) 71.76%.

Files Patch % Lines
chain/client/src/debug.rs 0.00% 4 Missing ⚠️
core/store/src/genesis/initialization.rs 60.00% 2 Missing ⚠️
chain/epoch-manager/src/adapter.rs 50.00% 1 Missing ⚠️
tools/amend-genesis/src/lib.rs 0.00% 1 Missing ⚠️
tools/fork-network/src/storage_mutator.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10271      +/-   ##
==========================================
- Coverage   71.80%   71.76%   -0.05%     
==========================================
  Files         711      711              
  Lines      142942   142936       -6     
  Branches   142942   142936       -6     
==========================================
- Hits       102646   102580      -66     
- Misses      35569    35625      +56     
- Partials     4727     4731       +4     
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (+<0.01%) ⬆️
db-migration 0.08% <0.00%> (+<0.01%) ⬆️
genesis-check 1.26% <0.00%> (+<0.01%) ⬆️
integration-tests 36.11% <51.72%> (-0.11%) ⬇️
linux 71.65% <68.96%> (-0.01%) ⬇️
linux-nightly 71.37% <68.96%> (-0.04%) ⬇️
macos 55.03% <53.57%> (+<0.01%) ⬆️
pytests 1.48% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.28% <0.00%> (+<0.01%) ⬆️
unittests 68.13% <53.57%> (-0.04%) ⬇️
upgradability 0.13% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit 90355d4 Dec 1, 2023
16 of 18 checks passed
@akhi3030 akhi3030 deleted the rm-num-shards branch December 1, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of num_shards()
2 participants