feat: Change default shard trie cache size to 500MB #10373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10373 +/- ##
=======================================
Coverage 71.92% 71.92%
=======================================
Files 717 717
Lines 143542 143542
Branches 143542 143542
=======================================
+ Hits 103243 103249 +6
+ Misses 35555 35545 -10
- Partials 4744 4748 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bowenwang1996
approved these changes
Dec 29, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Do not apply default size increase introduced in #10373 to `view_trie_cache` since view calls are not latency-sensitive * Opt out shard 1 from the increase since it only contains aurora account and based on the current metrics has very low cache miss rate even with a size of 50MB * Configure shard 3 override of 3GB to also apply after resharding
posvyatokum
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Do not apply default size increase introduced in #10373 to `view_trie_cache` since view calls are not latency-sensitive * Opt out shard 1 from the increase since it only contains aurora account and based on the current metrics has very low cache miss rate even with a size of 50MB * Configure shard 3 override of 3GB to also apply after resharding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current value is 50MB which might not be enough when the shard is overloaded. One example when this can be an issue is when delayed receipts queue grows to 20k+ items, which already happened during NEAT inscription load. Insufficient cache size results in increased number of disk reads to State rocksdb column. That increases chunk application time which results in more missed chunks.
This only applies to shards 0,1,2 since we have an overwrite for shard 3. So overall expected RAM increase is 3 * (500 - 50) = 1350MB.