refactor: use bytesize::ByteSize for TrieCacheConfig #10412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugachAG
added
C-housekeeping
pugachAG
force-pushed
the
trie-cache-config-types
branch
from
468473b
to
4f64ad3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10412 +/- ##
==========================================
+ Coverage 71.91% 71.92% +0.01%
==========================================
Files 719 719
Lines 144914 144936 +22
Branches 144914 144936 +22
==========================================
+ Hits 104211 104246 +35
+ Misses 35932 35909 -23
- Partials 4771 4781 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ekleog-NEAR
approved these changes
Jan 12, 2024
wacban
approved these changes
Jan 12, 2024
|
ByteSize parses integers as though they were a number of bytes, so I don’t see any potential for compatibility issues there :) |
wacban
reviewed
Jan 12, 2024
core/store/src/trie/config.rs
Outdated
| pub(crate) const DEFAULT_SHARD_CACHE_TOTAL_SIZE_LIMIT: u64 = | ||
| if cfg!(feature = "no_cache") { 1 } else { 50_000_000 }; | ||
| pub(crate) const DEFAULT_SHARD_CACHE_TOTAL_SIZE_LIMIT: bytesize::ByteSize = | ||
| if cfg!(feature = "no_cache") { bytesize::ByteSize::mb(1) } else { bytesize::ByteSize::mb(50) }; |
There was a problem hiding this comment.
Is the 1B -> 1MB intentional for the no cache case?
There was a problem hiding this comment.
ah, that was a mistake, thanks for catching!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #10409 (comment) to keep it consistent with the rest of
StoreConfig.