Disable auto-generation of wallet contract by default #10436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staffik
force-pushed
the
build-wallet-contract-flag
branch
from
13c1993
to
2271924
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10436 +/- ##
=======================================
Coverage 71.99% 71.99%
=======================================
Files 720 720
Lines 144954 144954
Branches 144954 144954
=======================================
+ Hits 104360 104361 +1
+ Misses 35811 35805 -6
- Partials 4783 4788 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sounds like you’ll need |
nagisa
approved these changes
Jan 16, 2024
Yes, in order to generate the file. Just |
birchmd
approved these changes
Jan 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
Looks like #10436 is not enough, because the WASM file is still generated if someone manually run tests with `--all-features` flag, which triggers `build_wallet_contract` too. To make sure it does not happen at all, I would disable the Wallect Contract build completely. We currently do not use it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances,
runtime/near-wallet-contract/build.rsis triggered and it regenerates the Wallet Contract WASM file for unrelated PRs: #10422 (comment).The
Wallet Contractwill be generated differently (#10269 (comment)), but for now I would like to include this tiny PR to stops auto-generating the WASM file by default.To test that the WASM file is not auto-regenerated, add a space to
runtime/near-wallet-contract/wallet-contract/src/lib.rsand runcargo build --features nightly.