rust: 1.77.0 #10856
rust: 1.77.0 #10856
Conversation
Release notes: https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html With split_last_chunk bunch of stdx code can now be deleted. \o/
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10856 +/- ##
==========================================
+ Coverage 71.39% 71.62% +0.22%
==========================================
Files 764 758 -6
Lines 154001 151734 -2267
Branches 154001 151734 -2267
==========================================
- Hits 109950 108672 -1278
+ Misses 39046 38521 -525
+ Partials 5005 4541 -464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -90,6 +90,7 @@ mod thunk; | |||
| /// | |||
| /// This means that the module is invalid. | |||
| #[derive(Debug)] | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Was this complaining about the field within the struct here (and elsewhere?) Is there a more granular lint we can allow than dead_code? Cause this I believe will keep this struct (or enum) around even after it becomes truly unused.
There was a problem hiding this comment.
Complain here I guess. ;)
But yeah, I’m not happy with this either. The best I can think of is to declare a dummy function with allow(dead_code) which accesses those fields.
There was a problem hiding this comment.
Turns out types in chain/client/src/adapter.rs weren’t used and Clippy failed to detect that for some reason. Does derive marks type as used perhaps? In which case allow(dead_code) won’t prevent unused type detection.
There was a problem hiding this comment.
Turns out types in chain/client/src/adapter.rs weren’t used and Clippy failed to detect that for some reason. Does derive marks type as used perhaps?
Might very well be some of the derives creating a use that's not obvious. e.g. maybe they put the type id into some sort of type registry?
Complain rust-lang/rust#85200 I guess. ;)
Ah, I see. I actually agree with the reasoning in the PR and would remove the field here.
|
Looks like the |
|
Yeah, that was next thing on my list. Had to update CI tools. Newer cargo-deny works fine. |
Release notes: https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html
With split_last_chunk bunch of stdx code can now be deleted. \o/
As for other changes:
Rust now doesn’t consider Clone and Debug derives as using fields of
a type. This lead to a handful of dead_code warnings. I’ve fixed
them by either removing offending type or adding
allow(dead_code).Cargo package id format has been stabilised¹ and krates crate
stopped working. Why do we care about that crate? It’s a dependency
of cargo-deny. To have CI pass I’ve updated taiki-e/install-action
so that it fetches the newest cargo-deny.
¹ rust-lang/cargo#12914