Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pytest): reenable store validator #11127

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

bowenwang1996
Copy link
Collaborator

Re-enable store validator tests that were disabled in #11022. It works by first sending a signal to GC actor to stop garbage collection, then run the store validator, and send a signal to re-enable gc afterwards.

Nayduck run https://nayduck.nearone.org/#/run/58

@bowenwang1996 bowenwang1996 requested a review from a team as a code owner April 20, 2024 18:16
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 48.78049% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 71.09%. Comparing base (a1a01b4) to head (4fe2638).
Report is 1 commits behind head on master.

Files Patch % Lines
chain/jsonrpc/src/lib.rs 20.00% 11 Missing and 1 partial ⚠️
chain/client/src/gc_actor.rs 43.75% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11127      +/-   ##
==========================================
- Coverage   71.10%   71.09%   -0.01%     
==========================================
  Files         772      772              
  Lines      153724   153759      +35     
  Branches   153724   153759      +35     
==========================================
+ Hits       109298   109311      +13     
- Misses      39976    39996      +20     
- Partials     4450     4452       +2     
Flag Coverage Δ
backward-compatibility 0.24% <0.00%> (-0.01%) ⬇️
db-migration 0.24% <0.00%> (-0.01%) ⬇️
genesis-check 1.43% <0.00%> (-0.01%) ⬇️
integration-tests 36.90% <43.90%> (+0.02%) ⬆️
linux 69.52% <100.00%> (+0.01%) ⬆️
linux-nightly 70.55% <48.78%> (-0.06%) ⬇️
macos 52.59% <100.00%> (-1.66%) ⬇️
pytests 1.66% <0.00%> (-0.01%) ⬇️
sanity-checks 1.44% <0.00%> (-0.01%) ⬇️
unittests 66.73% <48.78%> (-0.03%) ⬇️
upgradability 0.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Longarithm Longarithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me that adv_check_store was enabled already, we are just making it correct, and then I don't understand how the previous disabling of this check worked.
Anyway, approving to unblock

@bowenwang1996
Copy link
Collaborator Author

@Longarithm good catch! For some reason I forgot to do the actual change that re-enables store validator in pytests. It is now done in 4fe2638. Associated nayduck run to show no regression: https://nayduck.nearone.org/#/run/61

@bowenwang1996 bowenwang1996 added this pull request to the merge queue Apr 23, 2024
Merged via the queue into master with commit 8954a36 Apr 23, 2024
27 of 29 checks passed
@bowenwang1996 bowenwang1996 deleted the enable-store-validator branch April 23, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants