Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ft transfer benchmark] Add nearup to PATH #11395

Merged
merged 1 commit into from
May 27, 2024

Conversation

MCJOHN974
Copy link
Contributor

@MCJOHN974 MCJOHN974 commented May 24, 2024

Description of the script I changed: #11391.

I need to add this to $PATH, otherwise job inside cron don't see nearup and cargo. Probably it could be done in some more generic way, but I think since we want MVP asap this is fine.

Also added some lines to enrich logs and make debugging easier.

@MCJOHN974 MCJOHN974 requested a review from akhi3030 May 24, 2024 16:40
@MCJOHN974 MCJOHN974 requested a review from a team as a code owner May 24, 2024 16:40
@MCJOHN974 MCJOHN974 changed the title Add nearup to PATH [ft transfer benchmark] Add nearup to PATH May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.27%. Comparing base (66031e2) to head (790d4a8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11395      +/-   ##
==========================================
+ Coverage   71.24%   71.27%   +0.02%     
==========================================
  Files         784      784              
  Lines      157961   157847     -114     
  Branches   157961   157847     -114     
==========================================
- Hits       112539   112498      -41     
+ Misses      40567    40501      -66     
+ Partials     4855     4848       -7     
Flag Coverage Δ
backward-compatibility 0.24% <ø> (+<0.01%) ⬆️
db-migration 0.24% <ø> (+<0.01%) ⬆️
genesis-check 1.38% <ø> (+<0.01%) ⬆️
integration-tests 37.26% <ø> (+<0.01%) ⬆️
linux 68.79% <ø> (+0.05%) ⬆️
linux-nightly 70.70% <ø> (+0.04%) ⬆️
macos 52.37% <ø> (+0.04%) ⬆️
pytests 1.60% <ø> (+<0.01%) ⬆️
sanity-checks 1.39% <ø> (+<0.01%) ⬆️
unittests 65.70% <ø> (+0.06%) ⬆️
upgradability 0.29% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MCJOHN974
Copy link
Contributor Author

Now I, hopefully, fixed all problems with this PATH

@MCJOHN974 MCJOHN974 added this pull request to the merge queue May 27, 2024
Merged via the queue into master with commit 1ade93b May 27, 2024
28 of 29 checks passed
@MCJOHN974 MCJOHN974 deleted the viktar-ft-benchmark-script branch May 27, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants