vm: import construction → respective VM impls #11506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11506 +/- ##
==========================================
- Coverage 71.37% 71.37% -0.01%
==========================================
Files 790 790
Lines 160086 160087 +1
Branches 160086 160087 +1
==========================================
Hits 114256 114256
+ Misses 40857 40853 -4
- Partials 4973 4978 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nagisa
force-pushed
the
moves-around-import-code
branch
2 times, most recently
from
d98ecef to
204ec83
Compare
tayfunelmas
approved these changes
Jun 10, 2024
I always found it weird that we had VM specific code in what's a generic part of the near-vm-runner. Well -- it has actually started bothering me in real ways, so it gets moved. I didn't do very much to make sure it ends up pretty. And I don't think I want to for the VMs that're not wasmtime or near_vm. Good thing is that the wasmer0/2 code can be largely ignored sans changes to `VMLogic` (which I'm considering addressing next...)
nagisa
force-pushed
the
moves-around-import-code
branch
from
204ec83 to
eb02806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always found it weird that we had VM specific code in what's a generic
part of the near-vm-runner. Well -- it has actually started bothering me
in real ways, so it gets moved.
I didn't do very much to make sure it ends up pretty. And I don't think
I want to for the VMs that're not wasmtime or near_vm. Good thing is
that the wasmer0/2 code can be largely ignored sans changes to
VMLogic(which I'm considering addressing next...)
Based on top of #11503
Part of #11319