fix: spammy log - not a validator #11647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wacban
approved these changes
Jun 21, 2024
|
Added an issue #11648 |
jancionear
reviewed
Jun 21, 2024
Comment on lines
-113
to
-114
| } else { | ||
| tracing::error!(target: "client", new_block=?new_block.hash(), "Cannot process ready orphan witnesses - not a validator"); |
There was a problem hiding this comment.
Maybe a debug log would be OK? A log saying why a witness was discarded could be useful for debugging.
staffik
added a commit
that referenced
this pull request
Jun 25, 2024
See #11400 (comment) It seems non-validator nodes still call `process_ready_orphan_witnesses_and_clean_old` and logging an error in such case is spammy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11400 (comment)
It seems non-validator nodes still call
process_ready_orphan_witnesses_and_clean_oldand logging an error in such case is spammy.