Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: start lifting contract preparation up through tx runtime layers #11810

Merged
merged 16 commits into from
Jul 23, 2024

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    a53ba63 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Move local receipts into ApplyProcessingReceiptState

    With this all receipts are accounted for within this structure.
    
    Next up will be moving the iteration over receipts to happen internally
    within this structure, which would then allow us to also peek, etc.
    nagisa committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    fc990e0 View commit details
    Browse the repository at this point in the history
  2. runtime: change local receipt processing to use a queue

    This now allows introducing some hooks for pipelined preparation into
    the receipt execution loop.
    nagisa committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    b3dd149 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. vm: split out the contract code access into trait

    It appears that having the contract code access bundled into Externals
    wasn't particularly helping with lifting the contract preparation up. As
    a demo I have lifted the preparation to happen before the RuntimeExt is
    constructed...
    nagisa committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    056a9d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d98384 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0cb8076 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c68f479 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. fix view config

    nagisa committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    70c4ca7 View commit details
    Browse the repository at this point in the history
  2. fmt

    nagisa committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c19ca4d View commit details
    Browse the repository at this point in the history
  3. vm: Construct VMOutcome in run only

    This avoids a problem where in order to prepare a contract the NEAR
    balances of an account need to be known (in order to construct a
    `VMOutcome`) but also where the balance of an account might change by
    the time the VMOutcome is materialized to the caller as a result of them
    calling `run`.
    nagisa committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f63d3c5 View commit details
    Browse the repository at this point in the history
  4. vm: move method out of VMContext again

    `method` has been very recently moved into `VMContext` with the thought
    that `method` is closely related to the function call arguments which
    were already inside `VMContext`. However with `prepare` having been
    modified sufficiently to not rely on `VMContext`, `method` has again
    moved to be passed through a function argument. Keeping another instance
    of `method` inside `VMContext` would potentially allow for value
    confusion, as running a different method than what has been prepared is
    invalid.
    nagisa committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    cd8042b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    af27272 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d01f4a View commit details
    Browse the repository at this point in the history
  3. Fix CI

    nagisa committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    9b06c74 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    385d550 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. remove a piece of dead code

    This is not, strictly speaking dead-dead code. It is going to appear in
    a future change regardless, but is unnecessary in this PR.
    nagisa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    79170bc View commit details
    Browse the repository at this point in the history