Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: add a regression test for local receipts containing deploy actions #11897

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

nagisa
Copy link
Collaborator

@nagisa nagisa commented Aug 6, 2024

During the development of #11839 an issue was identified that involved the first local receipt containing a deploy action. This PR adds a regression test for that issue. While here I also took an opportunity to move the test suite into its own module since the original file was getting… way too large.

@nagisa nagisa requested a review from pugachAG August 6, 2024 11:55
@nagisa nagisa requested a review from a team as a code owner August 6, 2024 11:55
Copy link
Contributor

@pugachAG pugachAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that you've verified that the added test fails with #11839 implementation ignoring the first receipt

@nagisa nagisa enabled auto-merge August 6, 2024 17:14
@nagisa
Copy link
Collaborator Author

nagisa commented Aug 6, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Aug 6, 2024

@nagisa Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 2

Your contribution is much appreciated with a final score of 2!
You have received 20 Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

1.5k lines of inline tests is wayy excessive.
This is a regression test for an issue identified in a review of near#11839
@nagisa nagisa added this pull request to the merge queue Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.48%. Comparing base (6b5507a) to head (c6e8e53).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11897      +/-   ##
==========================================
- Coverage   71.72%   71.48%   -0.25%     
==========================================
  Files         809      810       +1     
  Lines      164629   163504    -1125     
  Branches   164629   163504    -1125     
==========================================
- Hits       118088   116882    -1206     
- Misses      41482    41573      +91     
+ Partials     5059     5049      -10     
Flag Coverage Δ
backward-compatibility 0.23% <ø> (-0.01%) ⬇️
db-migration 0.23% <ø> (-0.01%) ⬇️
genesis-check 1.34% <ø> (-0.01%) ⬇️
integration-tests 38.36% <ø> (+0.27%) ⬆️
linux 71.25% <ø> (-0.27%) ⬇️
linux-nightly 71.07% <ø> (-0.26%) ⬇️
macos 54.45% <ø> (-0.03%) ⬇️
pytests 1.60% <ø> (-0.01%) ⬇️
sanity-checks 1.41% <ø> (-0.01%) ⬇️
unittests 65.75% <ø> (-0.27%) ⬇️
upgradability 0.28% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit e98b6cc Aug 7, 2024
30 of 31 checks passed
@nagisa nagisa deleted the cleanup-runtime-tests branch August 7, 2024 15:49
@race-of-sloths
Copy link

🥁 Score it!

@pugachAG, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants