-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: add a regression test for local receipts containing deploy actions #11897
Conversation
d9c2432
to
1267c53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that you've verified that the added test fails with #11839 implementation ignoring the first receipt
@race-of-sloths include |
@nagisa Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 2! What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
1267c53
to
88b56b4
Compare
1.5k lines of inline tests is wayy excessive.
This is a regression test for an issue identified in a review of near#11839
88b56b4
to
c6e8e53
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11897 +/- ##
==========================================
- Coverage 71.72% 71.48% -0.25%
==========================================
Files 809 810 +1
Lines 164629 163504 -1125
Branches 164629 163504 -1125
==========================================
- Hits 118088 116882 -1206
- Misses 41482 41573 +91
+ Partials 5059 5049 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
🥁 Score it! @pugachAG, please score the PR with |
During the development of #11839 an issue was identified that involved the first local receipt containing a deploy action. This PR adds a regression test for that issue. While here I also took an opportunity to move the test suite into its own module since the original file was getting… way too large.