feat(resharding): log time spent in resharder operations #12238
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12238 +/- ##
==========================================
- Coverage 71.73% 71.72% -0.01%
==========================================
Files 835 835
Lines 166684 166646 -38
Branches 166684 166646 -38
==========================================
- Hits 119573 119534 -39
- Misses 41884 41889 +5
+ Partials 5227 5223 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| // TODO(Trisfald): metrics and logs | ||
| let time = timer.elapsed(); | ||
| batches_done += 1; | ||
| debug!(target: "resharding", ?time, ?batches_done, "flat storage resharding split shard batch processed"); |
There was a problem hiding this comment.
Why an event rather than another span?
There was a problem hiding this comment.
Do you mean span for the loop (or the whole function) + event for every finished iteration? Otherwise I don't understand why the span may be needed for this line.
There was a problem hiding this comment.
Switched to use a span
| @@ -310,6 +321,12 @@ impl FlatStorageResharder { | |||
|
|
|||
| /// Performs post-processing of shard splitting after all key-values have been moved from parent to | |||
| /// children. `success` indicates whether or not the previous phase was successful. | |||
| #[tracing::instrument( | |||
| level = "info", | |||
There was a problem hiding this comment.
is info appropriate here given that the instrumentations above are both debug?
There was a problem hiding this comment.
Good point, I've re-thought log levels in this file
Adding log entries telling the time spent on the longer operations happening during flat storage resharding.
Part of flat storage resharding issue (#12174).