feat: Refactor Config out of Runtime #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
evgenykuzyakov
changed the title
evgenykuzyakov
requested review from
bowenwang1996,
frol,
MaksymZavershynskyi,
olonho,
SkidanovAlex and
willemneal
as code owners
| @@ -113,6 +114,7 @@ impl EpochInfoProvider for SafeEpochManager { | |||
| /// TODO: this possibly should be merged with the runtime cargo or at least reconciled on the interfaces. | |||
| pub struct NightshadeRuntime { | |||
| genesis_config: GenesisConfig, | |||
| genesis_runtime_config: Arc<RuntimeConfig>, | |||
There was a problem hiding this comment.
why do we need to do this? runtime config is part of genesis_config
There was a problem hiding this comment.
You'd have to clone it every time to wrap into Arc
There was a problem hiding this comment.
It seems that you could implement it with lifetimes, but Arc is fine
There was a problem hiding this comment.
Lifetimes tend to poison code. It is better if we first solidify our codebase with smart pointers and then switch to references.
bowenwang1996
approved these changes
Oct 8, 2020
willemneal
approved these changes
Oct 8, 2020
frol
approved these changes
Oct 9, 2020
| @@ -113,6 +114,7 @@ impl EpochInfoProvider for SafeEpochManager { | |||
| /// TODO: this possibly should be merged with the runtime cargo or at least reconciled on the interfaces. | |||
| pub struct NightshadeRuntime { | |||
| genesis_config: GenesisConfig, | |||
| genesis_runtime_config: Arc<RuntimeConfig>, | |||
There was a problem hiding this comment.
It seems that you could implement it with lifetimes, but Arc is fine
MaksymZavershynskyi
approved these changes
Oct 10, 2020
| @@ -113,6 +114,7 @@ impl EpochInfoProvider for SafeEpochManager { | |||
| /// TODO: this possibly should be merged with the runtime cargo or at least reconciled on the interfaces. | |||
| pub struct NightshadeRuntime { | |||
| genesis_config: GenesisConfig, | |||
| genesis_runtime_config: Arc<RuntimeConfig>, | |||
There was a problem hiding this comment.
Lifetimes tend to poison code. It is better if we first solidify our codebase with smart pointers and then switch to references.
olonho
pushed a commit
that referenced
this pull request
Oct 15, 2020
Move `RuntimeConfig` from `Runtime` initialization to `ApplyState` object. This makes `Runtime` completely stateless and allows to execute transitions based on different configs. It allows to upgrade `RuntimeConfig` with the new fees based on the protocol version for the current block. This change should be NOOP and doesn't change the protocol. NEP: near/NEPs#120 Issue: #3158 # Test plan: - [X] CI - [x] http://nayduck.eastus.cloudapp.azure.com:3000/#/run/553
olonho
pushed a commit
that referenced
this pull request
Oct 19, 2020
Move `RuntimeConfig` from `Runtime` initialization to `ApplyState` object. This makes `Runtime` completely stateless and allows to execute transitions based on different configs. It allows to upgrade `RuntimeConfig` with the new fees based on the protocol version for the current block. This change should be NOOP and doesn't change the protocol. NEP: near/NEPs#120 Issue: #3158 # Test plan: - [X] CI - [x] http://nayduck.eastus.cloudapp.azure.com:3000/#/run/553
chefsale
pushed a commit
that referenced
this pull request
Oct 19, 2020
Move `RuntimeConfig` from `Runtime` initialization to `ApplyState` object. This makes `Runtime` completely stateless and allows to execute transitions based on different configs. It allows to upgrade `RuntimeConfig` with the new fees based on the protocol version for the current block. This change should be NOOP and doesn't change the protocol. NEP: near/NEPs#120 Issue: #3158 # Test plan: - [X] CI - [x] http://nayduck.eastus.cloudapp.azure.com:3000/#/run/553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
RuntimeConfigfromRuntimeinitialization toApplyStateobject.This makes
Runtimecompletely stateless and allows to execute transitions based on different configs.It allows to upgrade
RuntimeConfigwith the new fees based on the protocol version for the current block.This change should be NOOP and doesn't change the protocol.
NEP: near/NEPs#120
Issue: #3158
Test plan: