fix(runtime): add access key nonce range #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
evgenykuzyakov,
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
frol
approved these changes
Mar 9, 2021
bowenwang1996
force-pushed
the
add-access-key-nonce-range
branch
2 times, most recently
from
c717cc1
to
7590c89
Compare
bowenwang1996
force-pushed
the
add-access-key-nonce-range
branch
from
7590c89
to
7db1fbc
Compare
SkidanovAlex
approved these changes
Mar 10, 2021
evgenykuzyakov
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the access key nonce issue discussed here by setting nonce to
(block_height - 1) * 1e6and capping the access key nonces of transactions included in a block toblock_height * 1e6. Fixes #3779.Test plan
test_transaction_hash_collisiontest_chunk_transaction_validitytest_transaction_nonce_too_large