fix: wasmer1_default feature actually selects wasmer1 #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use this feature in ./runtime/near-vm-runner/src/vm_kind.rs. So, it should be declared in `vm_runner` Cargo.toml rather than in `vm_logic`.
matklad
requested review from
ailisp,
bowenwang1996,
EgorKulikov,
evgenykuzyakov and
olonho
as code owners
|
I think I orginialy broke that in #4225 |
chefsale
approved these changes
May 6, 2021
matklad
requested review from
frol,
MaksymZavershynskyi and
SkidanovAlex
as code owners
matklad
force-pushed
the
1.19.0-wasmer1-default-fix
branch
from
5f494af
to
9557e28
Compare
EgorKulikov
approved these changes
May 6, 2021
bowenwang1996
approved these changes
May 6, 2021
|
My understanding is that we don't actually need this for 1.19.0 release, as #4278 fixed the problem. I am going to close this PR and open a new one against the master branch. |
near-bulldozer bot
pushed a commit
that referenced
this pull request
May 7, 2021
We use this feature in ./runtime/near-vm-runner/src/vm_kind.rs. So, it should be declared in `vm_runner` Cargo.toml rather than in `vm_logic`. This is #4279 submitted against master. Not sure how to make sure that similar errors don't happen in the future. The culprit here is that you can have `cfg(feature = "some-typo")`, and you won't see any warnings about this anywhere...
chefsale
pushed a commit
that referenced
this pull request
May 12, 2021
We use this feature in ./runtime/near-vm-runner/src/vm_kind.rs. So, it should be declared in `vm_runner` Cargo.toml rather than in `vm_logic`. This is #4279 submitted against master. Not sure how to make sure that similar errors don't happen in the future. The culprit here is that you can have `cfg(feature = "some-typo")`, and you won't see any warnings about this anywhere...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this feature in ./runtime/near-vm-runner/src/vm_kind.rs.
So, it should be declared in
vm_runnerCargo.toml rather than invm_logic.