fix: correct feature handling #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on syntax-level understanding of the code, so please tripple-check. It seems that the old code flipped the order of if-branches: if the feature is not active at runtime, we should be doing the same thing as if the features is not enabled at compile time. Fix the issue by not repeating the code twice and leveraging the feature-checking macro instead.
|
Hm, looking at it more, it seems that I did write the branches in the wrong order here. Can someone quadruple-check this? That is, i do think that merging the three original cases into two cases guarded by |
matklad
added a commit
to matklad/nearcore
that referenced
this pull request
Oct 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on syntax-level understanding of the code, so please
tripple-check. It seems that the old code flipped the order of
if-branches: if the feature is not active at runtime, we should be doing
the same thing as if the features is not enabled at compile time.
Fix the issue by not repeating the code twice and leveraging the
feature-checking macro instead.