chain: refactor process_partial_encoded_chunk_request method
#6356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract two more methods from `process_partial_encoded_chunk_request` which correspond to `if` bodies that used to be in it. This makes each function shorter and thus easier to read especially as in the future more branches will be added to the method. Furthermore, move sending of the message to the method changing `maybe_send_partial_encoded_chunk_response` into method which prepares the response only. Issue: near#6242
mina86
requested review from
bowenwang1996,
mzhangmzz and
mm-near
as code owners
mm-near
approved these changes
Mar 1, 2022
| self.peer_manager_adapter.do_send(PeerManagerMessageRequest::NetworkRequests( | ||
| NetworkRequests::PartialEncodedChunkResponse { route_back, response }, | ||
| )) | ||
| } |
There was a problem hiding this comment.
in separate PR:
maybe we should have some stats - on how many times we don't have the response (as normally this should not happen).
mina86
added a commit
to mina86/nearcore
that referenced
this pull request
Apr 7, 2022
…6356) Extract two more methods from `process_partial_encoded_chunk_request` which correspond to `if` bodies that used to be in it. This makes each function shorter and thus easier to read especially as in the future more branches will be added to the method. Furthermore, move sending of the message to the method changing `maybe_send_partial_encoded_chunk_response` into method which prepares the response only. This is a pure refactoring with no changes to the behaviour. This is commit 62aa75a upstream. Issue: near#6242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract two more methods from
process_partial_encoded_chunk_requestwhich correspond to
ifbodies that used to be in it. This makes eachfunction shorter and thus easier to read especially as in the future
more branches will be added to the method.
Furthermore, move sending of the message to the method changing
maybe_send_partial_encoded_chunk_responseinto method which preparesthe response only.
This is a pure refactoring with no changes to the behaviour.
Issue: #6242