pytest: check reading chunks from storage in block_sync_archival.py #6376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ShardManager keeps cache of encoded chunks going back 1024 heights which means that nodes which request partial chunks for a recent block will be satisfied by data in the cache. This means that since only a hundred blocks are generated in block_sync_archival.py test, the code path where data is read from storage is never executed. Extend the test such that it generates 1500 blocks to make sure that both code paths are executed. Issue: #6242
mina86
requested review from
mm-near,
bowenwang1996 and
mzhangmzz
as code owners
mm-near
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ShardManager keeps cache of encoded chunks going back 1024 heights
which means that nodes which request partial chunks for a recent block
will be satisfied by data in the cache. This means that since only
a hundred blocks are generated in block_sync_archival.py test, the
code path where data is read from storage is never executed.
Extend the test such that it generates 1500 blocks to make sure that
both code paths are executed.
Issue: #6242