fix: Add v53 to config store #6556
Conversation
When updating near#6397 to protocol v53 right before merging, I forgot to add the configuration JSON file to the config store. Test plan --------- Added a test to verify that cost indeed increases.
| let tip = env.clients[0].chain.head().unwrap(); | ||
| let signed_transaction = | ||
| Transaction { nonce: 10, block_hash: tip.last_block_hash, ..tx.clone() }.sign(&signer); | ||
| let tx_hash = signed_transaction.get_hash(); | ||
| env.clients[0].process_tx(signed_transaction, false, false); | ||
| for i in 0..epoch_length { | ||
| env.produce_block(0, tip.height + i + 1); | ||
| } | ||
| env.clients[0].chain.get_final_transaction_result(&tx_hash).unwrap() |
There was a problem hiding this comment.
Perhaps wrap it in a closure so we can reuse it rather than duplicating the same code? This will make it obvious that we deploy the exact same contract.
There was a problem hiding this comment.
Yeah I like that. Done.
| let old_protocol_version = 52; | ||
| let new_protocol_version = 53; |
There was a problem hiding this comment.
Alternatively I would introduce a protocol feature like IncreaseDeploymentCost and use its protocol version (- 1).
I think of a scenario when we can postpone this feature to the v54 due to emergency reasons. Then it will be natural to modify protocol version of feature in the version.rs, but it can be easy to forget to fix two numbers in some test.
There was a problem hiding this comment.
You are right, I have now added this as an explicit protocol feature.
1) Add ProtocolFeature::IncreaseDeploymentCost 2) Move duplicated code into closure
|
Thank you! |
When updating #6397 to protocol v53 right before merging,
I forgot to add the configuration JSON file to the config store.
Test plan
Added a test to verify that cost indeed increases.