Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup feature handling in test contract #6620

Merged
merged 1 commit into from
Apr 15, 2022
Merged

refactor: cleanup feature handling in test contract #6620

merged 1 commit into from
Apr 15, 2022

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Apr 15, 2022

To land after #6564

@matklad matklad mentioned this pull request Apr 15, 2022
Merged
@matklad matklad force-pushed the m/cleanup-test-contract branch 3 times, most recently from 57f17b0 to ed7b3b4 Compare April 15, 2022 16:28
@matklad
refactor: cleanup feature handling in test contract
4b40127 
* use positive, non-negative feature
* remove one copy of test contract
* use consitent naming: test_contract, base_test_contract, nightly_test_contract
@matklad matklad force-pushed the m/cleanup-test-contract branch from ed7b3b4 to 4b40127 Compare April 15, 2022 16:58
@matklad matklad marked this pull request as ready for review April 15, 2022 18:55
@matklad matklad requested a review from a team as a code owner April 15, 2022 18:55
@matklad matklad requested a review from mm-near April 15, 2022 18:55
@matklad matklad requested review from mina86 and removed request for mm-near April 15, 2022 18:55
bowenwang1996
bowenwang1996 approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@bowenwang1996 bowenwang1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the latest protocol feature do?

@near-bulldozer near-bulldozer bot merged commit e187e33 into near:master Apr 15, 2022
@matklad matklad deleted the m/cleanup-test-contract branch May 11, 2022 13:55
@matklad
Copy link
Contributor Author

matklad commented May 11, 2022

Documented here:

https://github.com/near/nearcore/blob/master/runtime/near-test-contracts/src/lib.rs#L31-L57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenwang1996 bowenwang1996 bowenwang1996 approved these changes

@mina86 mina86 Awaiting requested review from mina86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @bowenwang1996