Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add {node,validator}_public_key field to /status response; deprecated node_key #7828

Merged
merged 5 commits into from
Oct 17, 2022
Merged

client: add {node,validator}_public_key field to /status response; deprecated node_key #7828

merged 5 commits into from
Oct 17, 2022

Commits on Oct 13, 2022

  1. client: add validator_key field and *real* node key to /status response 

    Currently, response to the /status request returns a `node_key` field.
However, the field does not include node key but rather validator key.
Rename this field to `validator_key`.

Furthermore, reuse `node_key` for the actually node key.

The massive problem with this change is of course that it will
silently break any existing code which thinks node_key in the response
is the validator key.

Fixes: near#7672
    @mina86
    mina86 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f3da8b7 View commit details
    Browse the repository at this point in the history

  2. wip

    @mina86
    mina86 committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    9fc692f View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. wip

    @mina86
    mina86 committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    bc24557 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'up/master' into HEAD

    @mina86
    mina86 committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    53544d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Merge branch 'master' into a

    @akhi3030
    akhi3030 authored Oct 17, 2022
    Configuration menu
    Copy the full SHA
    a38e041 View commit details
    Browse the repository at this point in the history