bump wasmparser to 0.94 #8119
Closed
bump wasmparser to 0.94 #8119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekleog-NEAR
force-pushed
the
wasmparser-bump
branch
from
9afe22d
to
f75672d
Compare
nagisa
reviewed
Nov 25, 2022
| extended_const: false, | ||
| mutable_global: true, | ||
| relaxed_simd: false, | ||
| saturating_float_to_int: true, |
There was a problem hiding this comment.
Similar comment as with the same change in wasmer PR – I believe these should be false, to avoid enabling new instructions we don't intend to support at this point in time. Especially because pwasm parser does not support them, but also enabling new instructions better be a conscious decision rather than an accidental one and keeping that in a separate PR would really help that.
nagisa
reviewed
Nov 25, 2022
| @@ -39,8 +39,8 @@ skip = [ | |||
| { name = "digest", version = "=0.9.0" }, | |||
| { name = "sha2", version = "=0.9.9" }, | |||
|
|
|||
| # near-vm-runner and wasmer-compiler-near use 0.78.2 | |||
| { name = "wasmparser", version = "=0.78.2" }, | |||
| # wasmtime uses 0.84.0 | |||
There was a problem hiding this comment.
Is there a reason for us to not update wasmtime? The most recent version (3.0) depends on 0.93.
There was a problem hiding this comment.
Not really; it’s just that it felt like something unrelated to the topic at-hand
|
Closing in favor of #8323, which does this plus much more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this as a draft PR, as we should not merge until near/wasmer#150 makes it in and we upgrade wasmer in nearcore to that version (we should upgrade wasmer and wasmparser around the same time)