Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow comments in config.json, genesis.json, node_key.json and validator_key.json #8423

Merged
merged 6 commits into from
Feb 1, 2023
Merged

feat: allow comments in config.json, genesis.json, node_key.json and validator_key.json #8423

merged 6 commits into from
Feb 1, 2023

Commits on Feb 1, 2023

  1. Use json_comments crate to skip config file comments

    @ppca
    ppca committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    fc46214 View commit details
    Browse the repository at this point in the history

  2. strip comments out from json for genesis_config.json, config.json, va… 

    …lidator_key.json and node_key.json
    @ppca
    ppca committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    2b6f5cf View commit details
    Browse the repository at this point in the history

  3. refactor code so that everywhere that needs to strip comments call th… 

    …e function from near-config-utils
    @ppca
    ppca committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9603071 View commit details
    Browse the repository at this point in the history

  4. add strip comments for reader and apply strip comments on more functi… 

    …ons for genesis config
    @ppca
    ppca committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    bef8781 View commit details
    Browse the repository at this point in the history

  5. change utils/config to be publish=true and add utils/config to global… 

    … toml in workspace
    @ppca
    ppca committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9aea825 View commit details
    Browse the repository at this point in the history

  6. more comments

    @ppca
    ppca committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    77a7f5d View commit details
    Browse the repository at this point in the history