Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use split store in the view client #8656

Merged
merged 8 commits into from
Mar 2, 2023
Merged

feat: use split store in the view client #8656

merged 8 commits into from
Mar 2, 2023

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Feb 28, 2023 •
edited
Loading

  • use split store in the view client - when configured
  • removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store
  • added SplitStorageConfig and used it to configure a few things

@wacban
Copy link
Contributor Author

wacban commented Feb 28, 2023

https://nayduck.near.org/#/run/2887

@wacban
Copy link
Contributor Author

wacban commented Feb 28, 2023

https://nayduck.near.org/#/run/2888

@wacban
Copy link
Contributor Author

wacban commented Mar 1, 2023

Some tests were failing in nayduck so I hid the split storage in view client behind a config that by default is false. Also configured a few other split storage things that will be handy to tune tests.

https://nayduck.near.org/#/run/2891

@wacban wacban marked this pull request as ready for review March 1, 2023 15:48
@wacban wacban requested a review from a team as a code owner March 1, 2023 15:48
nikurt
nikurt approved these changes Mar 2, 2023
View reviewed changes
core/store/src/lib.rs Outdated
Temperature::Cold => self.get_cold_store().unwrap(),
}
}
// pub fn get_store(&self, temp: Temperature) -> Store {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

@near-bulldozer near-bulldozer bot merged commit 173d546 into master Mar 2, 2023
@near-bulldozer near-bulldozer bot deleted the waclaw-cold-view-client branch March 2, 2023 12:11
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Mar 15, 2023
@wacban @nikurt
feat: use split store in the view client (near#8656)
a9b6463 
- use split store in the view client - when configured
- removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store
- added SplitStorageConfig and used it to configure a few things
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Mar 15, 2023
@wacban @nikurt
feat: use split store in the view client (near#8656)
f3ad60b 
- use split store in the view client - when configured
- removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store
- added SplitStorageConfig and used it to configure a few things
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Mar 20, 2023
@wacban @nikurt
feat: use split store in the view client (near#8656)
a8cfdaa 
- use split store in the view client - when configured
- removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store
- added SplitStorageConfig and used it to configure a few things
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Mar 23, 2023
@wacban @nikurt
feat: use split store in the view client (near#8656)
10a5765 
- use split store in the view client - when configured
- removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store
- added SplitStorageConfig and used it to configure a few things
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Apr 6, 2023
@wacban @nikurt
feat: use split store in the view client (near#8656)
7ac2bbc 
- use split store in the view client - when configured
- removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store
- added SplitStorageConfig and used it to configure a few things
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Apr 13, 2023
@wacban @nikurt
feat: use split store in the view client (near#8656)
b224412 
- use split store in the view client - when configured
- removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store
- added SplitStorageConfig and used it to configure a few things
nikurt pushed a commit that referenced this pull request Apr 14, 2023
@wacban @nikurt
feat: use split store in the view client (#8656)
b1cb591 
- use split store in the view client - when configured
- removed the get_store(Temperature) method and replaced usages with safer get_cold_store and get_hot_store
- added SplitStorageConfig and used it to configure a few things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikurt nikurt nikurt approved these changes

@posvyatokum posvyatokum Awaiting requested review from posvyatokum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wacban @nikurt