feat: flat storage rollout on nightly #8697
Conversation
Longarithm
changed the title
Longarithm
changed the title
| .sign(&signer); | ||
| let tx_hash = signed_transaction.get_hash(); | ||
| env.clients[0].process_tx(signed_transaction, false, false); | ||
| for i in 0..epoch_length / 3 { |
There was a problem hiding this comment.
why do we need to produce epoch_length / 3 blocks here?
There was a problem hiding this comment.
This is subtle. Added comment and linking this to #8703 for future reference
I confirmed that this issue with protocol auto-upgrade is still the case. Protocol version updates to latest after I process 4 epochs. I learned from somewhere that first 2 epochs are fine.
|
@jakmeier small note on |
|
As discussed, this will break Do we have a follow up on this comment already? https://near.zulipchat.com/#narrow/stream/297873-pagoda.2Fnode/topic/replayability.20and.20flat.20storage/near/342101682 |
| @@ -80,6 +80,7 @@ impl RuntimeUser { | |||
| apply_state: ApplyState, | |||
| prev_receipts: Vec<Receipt>, | |||
| transactions: Vec<SignedTransaction>, | |||
| use_flat_storage: bool, | |||
There was a problem hiding this comment.
Hm, I don't understand this flag, why wouldn't we want to use flat state in all tests?
There was a problem hiding this comment.
This is needed to check fallback to Trie, to defend from accidental protocol changes - if at some point we decide to implement this fallback, the new test requires doing it properly.
And such fallback is needed for view clients anyway, so I think it is valuable to have it here.
Here we switch from assertions of flat storage vs. trie reads to reads from flat storage only. Part of #8501.
Also moving
create_flat_storage_managertoFlatStorageManager::test- I need to reuse it in Runtime tests.Testing
test_storage_read_write_costs_runtime- runtime-specific test to check costs for subsequent storage read and write. It emphasizes the difference in costs before and after flat storage. Note that without flat storage we still can call contracts, but results, especially costs, will likely diverge from results on chain.test_flat_storage_upgrade- integration test for protocol upgrade correctness checkhttps://nayduck.near.org/#/run/2901https://nayduck.near.org/#/run/2907