Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boot nodes in fork_sync #8711

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Fix boot nodes in fork_sync #8711

merged 2 commits into from
Mar 10, 2023

Conversation

saketh-are
Copy link
Collaborator

This test spins up some nodes using start_cluster, then brings them down and back up again. They are brought back up with incorrectly configured boot_nodes, preventing them from reconnecting and causing the test to fail.

Before #8617 information about peers learned in the first run was persisted to disk, so the boot nodes configured when restarting the nodes didn't matter.

@saketh-are saketh-are marked this pull request as ready for review March 10, 2023 13:30
@saketh-are saketh-are requested a review from a team as a code owner March 10, 2023 13:30
@saketh-are saketh-are requested review from akhi3030 and removed request for akhi3030 March 10, 2023 13:30
@akhi3030
Copy link
Collaborator

@marcelo-gonzalez: please ping me when you are ready to have the PR merged and I'll approve.

@saketh-are saketh-are merged commit eebfe23 into master Mar 10, 2023
@saketh-are saketh-are deleted the fix_fork_sync_boot_nodes branch March 10, 2023 14:56
marcelo-gonzalez added a commit to marcelo-gonzalez/nearcore that referenced this pull request Mar 11, 2023
@marcelo-gonzalez
fix(pytest): set boot nodes in recompress_storage.py
24a84cc 
this is a fix similar to
near#8711. After
near#8617, we need to correctly set
the boot nodes in this test, otherwise we get a timeout error in
test_tx_status() after the nodes are restarted
@marcelo-gonzalez marcelo-gonzalez mentioned this pull request Mar 11, 2023
Merged
near-bulldozer bot pushed a commit that referenced this pull request Mar 14, 2023
@marcelo-gonzalez
fix(pytest): set boot nodes in recompress_storage.py (#8715)
c73b86c 
this is a fix similar to
#8711. After
#8617, we need to correctly set the boot nodes in this test, otherwise we get a timeout error in test_tx_status() after the nodes are restarted
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Mar 15, 2023
@saketh-are @nikurt
fork_sync: fix boot nodes (near#8711)
ca3967e
nikurt pushed a commit to nikurt/nearcore that referenced this pull request Mar 15, 2023
@marcelo-gonzalez @nikurt
fix(pytest): set boot nodes in recompress_storage.py (near#8715)
49e4e77 
this is a fix similar to
near#8711. After
near#8617, we need to correctly set the boot nodes in this test, otherwise we get a timeout error in test_tx_status() after the nodes are restarted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhi3030 akhi3030 akhi3030 approved these changes

@marcelo-gonzalez marcelo-gonzalez marcelo-gonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saketh-are @akhi3030 @marcelo-gonzalez