fix: apply log_summary_style to state sync phase message
#8735
Conversation
| @@ -176,6 +177,7 @@ impl StateSync { | |||
| now: DateTime<Utc>, | |||
| state_parts_task_scheduler: &dyn Fn(ApplyStatePartsRequest), | |||
| state_split_scheduler: &dyn Fn(StateSplitRequest), | |||
| use_colour: bool, | |||
There was a problem hiding this comment.
Somewhat unfortunate that we must thread this through like that…
| } | ||
| _ => unreachable!("timeout cannot happen when all state is downloaded"), | ||
| }, | ||
| phase = format_shard_sync_phase(&shard_sync_download, use_colour), |
There was a problem hiding this comment.
I wonder if this would be better served by splitting the phase up into different tracing KVs? for example state_requests_count and last_target could both easily be KVs I think 🤔
Though adding colors to that would be even harder.
There was a problem hiding this comment.
I'm worried about the StateDownloadParts branch. Some shards have a lot of shards, which results in huge log messages. I definitely don't want to export 50k tracing KVs from a single span.
At the moment, this way-too-verbose logging is still useful for development of State Sync. Currently, I'm leaning to refactoring the code and keeping the logging.
I'll consider simplifying the log line in the future. Coutning the number of done/not-done parts should be useful enough in most cases.
* Use colour for state sync phase display * fix * fix * debug verbosity * fix
* Use colour for state sync phase display * fix * fix * debug verbosity * fix
* Use colour for state sync phase display * fix * fix * debug verbosity * fix
* Use colour for state sync phase display * fix * fix * debug verbosity * fix
No description provided.