feat: Rosetta supports delegate action #8750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encody
commented
Mar 21, 2023
chain/rosetta-rpc/src/adapters/validated_operations/signed_delegate_action.rs
Outdated
Show resolved
Hide resolved
encody
commented
Mar 21, 2023
chain/rosetta-rpc/src/adapters/validated_operations/delegate_action.rs
Outdated
Show resolved
Hide resolved
|
@firatNEAR: I don't think you have codeowner rights. Let me know when you are happy with the PR and I can greenlight it. |
firatNEAR
requested changes
Mar 22, 2023
chain/rosetta-rpc/src/adapters/validated_operations/delegate_action.rs
Outdated
Show resolved
Hide resolved
firatNEAR
approved these changes
Mar 22, 2023
|
@firatNEAR, @encody: should another engineer in the protocol also review the PR or are you comfortable merging? |
|
@akhi3030 This is only an update to the Rosetta RPC. |
firatNEAR
reviewed
Mar 23, 2023
chain/rosetta-rpc/src/adapters/validated_operations/delegate_action.rs
Outdated
Show resolved
Hide resolved
|
I think we are confident with this PR being merged after the comments are resolved. |
akhi3030
approved these changes
Mar 23, 2023
|
Merge because of possibly spurious test failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #8469