-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix publish pipeline #9057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on fixing this!
One small question in the comments.
Plus one question for my broader understanding: You have patched your private cargo workspaces fork, right? How is our dependency on that defined and how do we get the the updates?
edition = "2021" | ||
license = "MIT OR Apache-2.0" | ||
repository = "https://github.com/near/nearcore" | ||
rust-version = "1.64.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to update this? Any reason to update to this version in particular?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Yeah, I tested it against all the rust versions from 1.60
, it's MSRV is now 1.64
since the crate now uses workspace inheritance that was stabilized at 1.64
.
Yeah, it's been updated. I was hoping to eventually merge those patches to the upstream repo, but I don't think that's happening anymore (at least not anytime soon). So I'll keep maintaining my repo. Once we merge this, CI will pull from that repo, build a binary and use that to publish our crates (pipeline). Once it's verifiably green, I'll tag that commit and update our CI pipeline to source from that tag. I'll have a think to see if I want to have the crate published to crates.io under a different name, would be ideal to source the updates from there. The pattern for introducing new crates should be much simplified now as this PR lays a structure that can be adapted and reused. |
The publishing pipeline has been borked for quite a while for a variety of reasons, between workspace inheritance, crate aliases, etc..
This patch is only one part of the solution. The rest of it is patched in a fork of cargo-workspaces: miraclx/cargo-workspaces#1.
That patch also now includes pre-emptive error reports, which would help move any potential errors thrown at CI runtime on master to CI runtime at the PR level.
I'll extend the buildkite pipeline in a bit.(this will come in a follow-up PR)Fixes #8604.
Further context: #8605