fix: tests for invalid state parts #9122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jakmeier
approved these changes
May 30, 2023
|
Also added checks for duplicated value and shuffled state part. |
nikurt
pushed a commit
that referenced
this pull request
May 31, 2023
Check that invalid state parts don't pass validation. Add missing `StorageError` kind for one of test cases. Now we check two scenarios: * MissingTrieValue - should be returned if some trie value is missing during validation - e.g. some intermediate node wasn't sent; * UnexpectedTrieValue - should be returned if some extra trie value was included to state part. Necessary to check, otherwise malicious actor can spam nodes with large amounts of non-existent nodes.
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Jun 8, 2023
Check that invalid state parts don't pass validation. Add missing `StorageError` kind for one of test cases. Now we check two scenarios: * MissingTrieValue - should be returned if some trie value is missing during validation - e.g. some intermediate node wasn't sent; * UnexpectedTrieValue - should be returned if some extra trie value was included to state part. Necessary to check, otherwise malicious actor can spam nodes with large amounts of non-existent nodes.
nikurt
pushed a commit
to nikurt/nearcore
that referenced
this pull request
Jun 8, 2023
Check that invalid state parts don't pass validation. Add missing `StorageError` kind for one of test cases. Now we check two scenarios: * MissingTrieValue - should be returned if some trie value is missing during validation - e.g. some intermediate node wasn't sent; * UnexpectedTrieValue - should be returned if some extra trie value was included to state part. Necessary to check, otherwise malicious actor can spam nodes with large amounts of non-existent nodes.
nikurt
pushed a commit
that referenced
this pull request
Jun 13, 2023
Check that invalid state parts don't pass validation. Add missing `StorageError` kind for one of test cases. Now we check two scenarios: * MissingTrieValue - should be returned if some trie value is missing during validation - e.g. some intermediate node wasn't sent; * UnexpectedTrieValue - should be returned if some extra trie value was included to state part. Necessary to check, otherwise malicious actor can spam nodes with large amounts of non-existent nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that invalid state parts don't pass validation. Add missing
StorageErrorkind for one of test cases. Now we check two scenarios: