Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move DataReceiver to near-vm-errors #9211

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

Ekleog-NEAR
Copy link
Collaborator

@Ekleog-NEAR Ekleog-NEAR commented Jun 16, 2023

See #9176 for the rationale, near-vm-errors will be merged into
near-vm-runner as soon as circular dependencies are done for.

see #8197

@Ekleog-NEAR Ekleog-NEAR requested a review from a team as a code owner June 16, 2023 12:23
See near#9176 for the rationale, near-vm-errors will be merged into
near-vm-runner as soon as circular dependencies are done for.
@Ekleog-NEAR Ekleog-NEAR added the C-housekeeping Category: Refactoring, cleanups, code quality label Jun 16, 2023
@Ekleog-NEAR Ekleog-NEAR modified the milestone: 6143 Jun 16, 2023
@nagisa
Copy link
Collaborator

nagisa commented Jun 19, 2023

How do you anticipate disentanging the only(?) direct user of this DataReceiver type – ActionReceipt? Also move that to near_vm_errors? It seems to me like it would be better to group some of those other types into the same PR in this instance.

@Ekleog-NEAR
Copy link
Collaborator Author

I’m not planning on disentangling ActionReceipt yet; currently my goal is to remove the dependency of near-vm-logic on near-primitives, because it blocks the merge of near-vm-errors for circular dependency reasons. And my impression (though I haven’t finalized the PR moving near_primitives::Action to near-vm-errors yet, with it being the last blocker to remove the dep from near-primitives I think) is that I won’t have to touch it for the currently planned merge.

@Ekleog-NEAR
Copy link
Collaborator Author

#9217 concludes what’s needed to remove the dependency from near-vm-logic to near-primitives and thus hopefully finally being able to merge near-vm-errors and near-vm-runner. It confirms I don’t think we need to deal with ActionReceipt yet — TBH I think it’ll probably have to be merged into node-runtime but not before, judging from its current uses

@near-bulldozer near-bulldozer bot merged commit 6f48e62 into near:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants