fix(state-sync): Remove state_fetch_horizon because it causes nodes to crash
#9380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikurt
changed the title
state_fetch_horizon because it causes nodes to crash
pugachAG
approved these changes
Aug 7, 2023
nikurt
changed the title
state_fetch_horizon because it causes nodes to crashstate_fetch_horizon because it causes nodes to crash
ppca
reviewed
Aug 7, 2023
ppca
approved these changes
Aug 7, 2023
ppca
pushed a commit
that referenced
this pull request
Aug 9, 2023
… to crash (#9380) The main issue is that `find_sync_hash()` is not consistent with `check_state_needed()`. `check_state_needed` compares epoch_id of header_head and head. `find_sync_hash()` moves back a number of blocks before determining which epoch to sync. It can lead to a node deciding to state sync, and downloading the same state again. I've observed that it leads to a crash in this complicated scenario: * State sync to epoch X * Finalize the state sync and execute block at height H * Check orphans and unblock a block at height H+1 * At the same time check if a node needs a state sync - determine that yes, and reset Flat Storage to prepare it to execute a block at height H. * The orhpaned block gets executed, but flat storage doesn't support height H+1, leading to a panic.
nikurt
added a commit
that referenced
this pull request
Aug 24, 2023
… to crash (#9380) The main issue is that `find_sync_hash()` is not consistent with `check_state_needed()`. `check_state_needed` compares epoch_id of header_head and head. `find_sync_hash()` moves back a number of blocks before determining which epoch to sync. It can lead to a node deciding to state sync, and downloading the same state again. I've observed that it leads to a crash in this complicated scenario: * State sync to epoch X * Finalize the state sync and execute block at height H * Check orphans and unblock a block at height H+1 * At the same time check if a node needs a state sync - determine that yes, and reset Flat Storage to prepare it to execute a block at height H. * The orhpaned block gets executed, but flat storage doesn't support height H+1, leading to a panic.
nikurt
added a commit
to nikurt/nearcore
that referenced
this pull request
Aug 24, 2023
… to crash (near#9380) The main issue is that `find_sync_hash()` is not consistent with `check_state_needed()`. `check_state_needed` compares epoch_id of header_head and head. `find_sync_hash()` moves back a number of blocks before determining which epoch to sync. It can lead to a node deciding to state sync, and downloading the same state again. I've observed that it leads to a crash in this complicated scenario: * State sync to epoch X * Finalize the state sync and execute block at height H * Check orphans and unblock a block at height H+1 * At the same time check if a node needs a state sync - determine that yes, and reset Flat Storage to prepare it to execute a block at height H. * The orhpaned block gets executed, but flat storage doesn't support height H+1, leading to a panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue is that
find_sync_hash()is not consistent withcheck_state_needed().check_state_neededcompares epoch_id of header_head and head.find_sync_hash()moves back a number of blocks before determining which epoch to sync.It can lead to a node deciding to state sync, and downloading the same state again.
I've observed that it leads to a crash in this complicated scenario: