refactor: Remove async indexer_rules_engine
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
commented
Nov 13, 2023
| @@ -0,0 +1,3551 @@ | |||
| { | |||
There was a problem hiding this comment.
Added as indexer_rules_engine tests depend on it
darunrs
approved these changes
Nov 13, 2023
| @@ -204,6 +204,7 @@ mod tests { | |||
| /// Parses env vars from .env, Run with | |||
| /// cargo test s3::tests::list_delta_bucket -- mainnet from-latest; | |||
| #[tokio::test] | |||
| #[ignore] | |||
There was a problem hiding this comment.
Did you intend to leave all of these ignores around?
EDIT: Nevermind. I read your commit message again. Why did the tests not work anymore actually?
There was a problem hiding this comment.
They do, but they rely on external sources and AWS access keys so I didn't want to run them in CI. They're mostly run locally so in that case the #[ignore] can be removed then.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two versions of
indexer_rules_engine; sync and async. This logic does not need to beasyncso I've removed this version and refactored so only the sync version is used.Additionally, I've migrated the
asynctests across to use thesyncversion, and have addedcargo testto Github Actions so that they are always run. This required fixing theset_provisioning_flagtest, as well as ignoring the integration tests which rely on AWS access keys.