feat: Update frontend to handle new registry types #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
feat/start-block-continue-ui
branch
from
31d9a9b
to
5d04394
Compare
morgsmccauley
force-pushed
the
feat/start-block-continue-ui
branch
from
5d04394
to
655e734
Compare
morgsmccauley
changed the title
darunrs
approved these changes
Feb 21, 2024
| HEIGHT: indexerConfig.height | ||
| }; | ||
| } else if (indexerConfig.startBlock === "startBlockLatest") { | ||
| startBlock = "LATEST"; |
There was a problem hiding this comment.
How come startBlockHeight sets startBlock to an object whereas latest and continue set it to a string? Is this a quirk of the way the new register function expects it?
| <Form.Control | ||
| value={contractFilter} | ||
| onChange={handleSetContractFilter} | ||
| value={startBlock === START_BLOCK.CONTINUE ? indexerDetails.rule.affected_account_id : contractFilter} |
There was a problem hiding this comment.
Is it possible to change the filter on LATEST, then check CONTINUE and it publishes new filter IDs anyway?
There was a problem hiding this comment.
Nope, when we change to CONTINUE, the filter gets reset back to the original state :)
frontend/src/components/Form/IndexerConfigOptionsInputGroup.jsx
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the frontend to work with the updated registry contract types/methods. There are two parts to this change:
ruleandstartBlock, and writing these types back during registrationStartBlock::Continueoption, which allows developers to resume the existing block stream.I've attached images of the updated UI for reference. Note that updating the contract filter is disabled with the new "Continue" option.