refactor: Introduce struct to manager persistent indexer state #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
feat/indexer-state
branch
from
041a5fe
to
4a752e7
Compare
morgsmccauley
commented
May 9, 2024
| @@ -52,9 +55,18 @@ async fn main() -> anyhow::Result<()> { | |||
| loop { | |||
| let indexer_registry = registry.fetch().await?; | |||
|
|
|||
| indexer_state_manager | |||
| .migrate_state_if_needed(&indexer_registry) | |||
There was a problem hiding this comment.
Migrating "stream versions" to new indexer state objects
morgsmccauley
commented
May 9, 2024
| pub async fn is_migration_complete(&self) -> anyhow::Result<Option<bool>>; | ||
| } | ||
|
|
||
| impl Clone for RedisClientImpl { |
There was a problem hiding this comment.
Need to manually mock RedisClient so Clone is available on the mock object.
morgsmccauley
force-pushed
the
feat/indexer-state
branch
from
4a752e7
to
550eefe
Compare
gabehamilton
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR centralises persistent Indexer State within the
IndexerStateManagerstruct. Currently, we only persist the "stream version", but this will soon grow to "enabled/disabled", which will be implemented in my next PR. This is just a tidy up to make the next step a bit easier.Indexer state will be stored as stringified JSON under
{account_id}/{function_name}:state, currently this only includes when the block stream was last synced. I've included a migration step in to move from the old key/structure to the new.