Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency resolution required - upgraded eslint to ^8.56.0 #765

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Kevin101Zhang
Copy link
Contributor

@typescript-eslint/eslint-plugin and @typescript-eslint/parser required by your project and the versions required by ESLint. Specifically, ESLint requires version ^8.56.0 of @typescript-eslint/parser, while your project requires version ^7.9.0.

https://console.cloud.google.com/cloud-build/builds/1825a649-e414-4a72-8c68-5c50625d128f;step=0?project=pagoda-data-stack-dev

@Kevin101Zhang Kevin101Zhang linked an issue Jun 4, 2024 that may be closed by this pull request
@Kevin101Zhang Kevin101Zhang marked this pull request as ready for review June 4, 2024 18:41
@Kevin101Zhang Kevin101Zhang requested a review from a team as a code owner June 4, 2024 18:41
@Kevin101Zhang
Copy link
Contributor Author

The problem is from conflicting versions of dependencies, involving ESLint and its related packages
(@typescript-eslint/eslint-plugin and @typescript-eslint/parser).

In the original package.json, ESLint is set to version 8.50.0, while @typescript-eslint/eslint-plugin and @typescript-eslint/parser are set to version ^7.9.0. However, ESLint's requirement of @typescript-eslint/parser is ^8.56.0. Upgrading ESLint to version 8.56.0 should resolves this conflict.

@darunrs
Copy link
Collaborator

darunrs commented Jun 4, 2024

Do you mind doing a docker build to be sure? I think if you build all of your QueryApi dockers, it should confirm the issue is resolved.

Copy link
Collaborator

@darunrs darunrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why some of the others like block-sstreamer had their build cancelled by some user? Not sure if this is related.

@Kevin101Zhang Kevin101Zhang merged commit 9e723b2 into main Jun 4, 2024
@Kevin101Zhang Kevin101Zhang deleted the 764-frontend-dependency-conflict branch June 4, 2024 20:15
@Kevin101Zhang Kevin101Zhang restored the 764-frontend-dependency-conflict branch June 4, 2024 20:35
@Kevin101Zhang Kevin101Zhang changed the title upgraded eslint to ^8.56.0 fix: dependency resolution required - upgraded eslint to ^8.56.0 Jul 24, 2024
@Kevin101Zhang Kevin101Zhang deleted the 764-frontend-dependency-conflict branch August 8, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend Dependency Conflict
2 participants