Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable eslint rules #767

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore: disable eslint rules #767

merged 1 commit into from
Jun 4, 2024

Conversation

Kevin101Zhang
Copy link
Contributor

@Kevin101Zhang Kevin101Zhang commented Jun 4, 2024 •
edited
Loading

Disabled some lint rules causing build to fail. Run local build and it succeeds.

@Kevin101Zhang Kevin101Zhang linked an issue Jun 4, 2024 that may be closed by this pull request
Missing Eslint Rules #766
Closed
@Kevin101Zhang Kevin101Zhang marked this pull request as ready for review June 4, 2024 21:53
@Kevin101Zhang Kevin101Zhang requested a review from a team as a code owner June 4, 2024 21:53
darunrs
darunrs approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@darunrs darunrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth slotting some time this week to look into what changes led to the different build failures, especially why some ESLint errors suddenly started blocking builds.

@Kevin101Zhang Kevin101Zhang merged commit ffceeef into main Jun 4, 2024
@Kevin101Zhang Kevin101Zhang deleted the 766-missing-eslint-rules branch June 4, 2024 21:59
@Kevin101Zhang Kevin101Zhang changed the title disable eslint rules chore: disable eslint rules Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darunrs darunrs darunrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Eslint Rules
2 participants
@Kevin101Zhang @darunrs