feat: Removed Yarn (in favor of NPM ), Updated Docker, Reran/updated packages. #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dependency versions
Kevin101Zhang
changed the title
|
Testing:
|
morgsmccauley
approved these changes
Jun 11, 2024
Closed
Merged
Kevin101Zhang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously managed our packages with two different package managers, which often led to confusion and inconsistencies within the repository. Some parts of the codebase used Yarn, while others, like Docker configurations, relied on npm.
This setup resulted in numerous dependency mismatches/conflucts, duplicate caching and storage, and larger build times. To align with the majority of our repository, which already uses npm (e.g., our runner scripts), I remove Yarn entirely and standardize on npm. I eliminated all references to Yarn, including removing the yarn.lock file/cache. Additionally, we updated our Dockerfile from using Node.js version 16 to version 18 to meet the requirements of our applications and removed the reference to yarn in our dockerfile. Which is odd because our local dockerfile used yarn while our dockerfile on gcp references npm?