refactor: Unify logic for generating Redis keys #807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the
IndexerState
andIndexerConfig
structs are used individually to access Redis, and therefore have duplicate code for generating the required keys. This is problematic for the following reasons:This PR creates a common Redis
KeyProvider
interface/trait for accessing Indexer Redis data/keys. Now the required structs, i.e.IndexerState
andIndexerConfig
, can implement this trait, and automatically get access to the methods which generate the keys.Also did some minor clean up, removing the old Coordinator migration code.