fix: Support array values for queries and string type for inserts #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darunrs
commented
Jul 11, 2024
| @@ -204,30 +204,33 @@ export class PgSchemaTypeGen { | |||
|
|
|||
| tableList.add(sanitizedTableName); | |||
|
|
|||
| let queryDefinition = `declare interface ${sanitizedTableName}Query {\n`; | |||
There was a problem hiding this comment.
I will actually get rid of this file relatively soon in favor of a new class in Runner which handles Postgres DLL Parsing logic. Part of its functionality will be producing the TS file string. This will prevent issues like this in the future where backend features get supported while the frontend acts as though it isn't supported.
morgsmccauley
approved these changes
Jul 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context DB in the frontend was showing an error for inserts and select. For inserts, some types such as
datewould expectDatetype when string type also works. I updated the type gen to allow string type input for these options. This ensures string or number input is acceptable for essentially all types.In addition, selection queries allow for array input to match muliple values for a certain column. However, the frontend was not updated to accept this input. I've added a new interface called Query which allows for array values in input objects.
![Uploading image.png…]()